Render async timeouts in the listener, as Jetty 9 requires #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviews welcome, but I'm going to do a release candidate so we can test this on the open Jetty PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the issue in http4s/http4s-jetty#118.
The problem here is that we need to call
complete()on the same thread that receives theonTimeout()(see jetty/jetty.project#6227). Instead of racing a timeout response against the service response and rendering the winner, we race a unit callback against the service response, and render the timeout response using the Servlet API. We only callcontext.complete()wherever we actually render the response.