Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash when 'options.target' is an object instead a string #1600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

crash when 'options.target' is an object instead a string #1600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/http-proxy/passes/web-outgoing.js
View file
Open in desktop
Expand Up @@ -51,7 +51,8 @@ module.exports = { // <--
if ((options.hostRewrite || options.autoRewrite || options.protocolRewrite)
&& proxyRes.headers['location']
&& redirectRegex.test(proxyRes.statusCode)) {
var target = url.parse(options.target);
const targetStr = typeof options.target === 'string' ? options.target : options.target.href;
var target = url.parse(targetStr);
var u = url.parse(proxyRes.headers['location']);

// make sure the redirected host matches the target host before rewriting
Expand Down