Add simple implementation of serving directories as zip files #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thornjad, perhaps you can help clear some of these up when you have time and energy? (In any case, thanks for this great utility. 😄) |
kimsey0
commented
Oct 4, 2022
| @@ -352,6 +353,9 @@ module.exports = function createMiddleware(_dir, _options) { | |||
| // This means we're already trying ./404.html and can not find it. | |||
| // So send plain text response with 404 status code | |||
| status[404](res, next); | |||
| } else if (path.extname(parsed.pathname) === '.zip' && opts.serveDirZip) { | |||
There was a problem hiding this comment.
This should probably be case insensitive.
|
@thornjad, any chance you could answer a few of the questions above? 😄 |
|
@thornjad, any input on whether this could conceivably merge in the right state? |
|
This pull request has been inactive for 360 days |
|
@thornjad, I still think this would be useful. Any chance you think so too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of a new functionality that allows downloading the contents of a directory as a zip file. See the issue linked below for why I think this would be useful.
It's implemented using the archiver library, which allows streaming the compressed files directly to the response. There are currently no automated tests, but the feature can be manually tested without any additional setup by running
npm startand visiting http://localhost:8080/img.zip.Questions I'd like answered before I continue the work:
http-server?archiveradds quite a few transitive dependencies. The number could probably be reduced by using a lower-level library like zip-stream at the cost of more complex wrapping code.--serve-dir-zipcommand line argument that controls it. Should it be enabled by default?/directory/.zipinstead of/directory.zip.archiver, so it's trivial to enable.Relevant issues
Fixes #798.
Contributor checklist
--helpoutputmasterbranchMaintainer checklist