Close server port on exit #823
Conversation
| }).on('SIGINT', function () { | ||
| process.emit('SIGINT'); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Moved the block for Windows to the bottom, so that the reading order becomes natural.
| server.close(); | ||
| logger.info(chalk.red('http-server stopped.')); | ||
| process.exit(); | ||
| } |
There was a problem hiding this comment.
Refactored from the common code below.
| }); | ||
| } | ||
| function stopServer() { | ||
| server.close(); |
There was a problem hiding this comment.
The main purpose of this PR is to add this server.close(); line.
|
To maintainers: |
I've updated the code to set up "CTRL-C" hook, before printing out "Hit CTRL-C to stop the server". It's because the parent process relies on "Hit CTRL-C to stop the server" (or "Available on: ...") to know that http-server is ready. But at this time in the old code, the "CTRL-C" hook hasn't been set up yet. If the parent process kills http-server at this time, the port will still be open. |
|
This pull request has been inactive for 360 days |
When http-server is spawned as a child process, when it exits (uppon
SIGINT/SIGTERM), in certain conditions (depending on platforms and the platform conditions, it's hard to reliably reproduce), the port may still be open.When the parent process tries to run http-server on the same port again, it will fail as the port is still open.
This PR fixes the problem by closing the port on exit.
Relevant issues
Contributor checklist
masterbranchMaintainer checklist