Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure headers are not set twice on error #791

Merged
merged 1 commit into from May 31, 2022

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Jan 23, 2022

Handle the case when headers are already sent because of an error -- we want to report the error, not hide it behind "headers already sent". Also bump Node requirement to match versions not affected by #756 .

Relevant issues

#756

Contributor checklist
  • Provide tests for the changes (unless documentation-only)
  • Documented any new features, CLI switches, etc. (if applicable)
    • Server --help output
    • README.md
    • doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

@zbynek
Copy link
Contributor Author

zbynek commented Apr 4, 2022

@thornjad ping

@thornjad thornjad merged commit 8f7fcb0 into http-party:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants