Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zalgo spam from colors #783

Closed
wants to merge 1 commit into from

Conversation

dballance
Copy link

@dballance dballance commented Jan 9, 2022

See: Marak/colors.js#285 (comment)

Resolves #781

Relevant issues

See: Marak/colors.js#285 (comment)

Resolves #781

Contributor checklist
  • Provide tests for the changes (unless documentation-only)
  • Documented any new features, CLI switches, etc. (if applicable)
    • Server --help output
    • README.md
    • doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

@zbynek
Copy link
Contributor

zbynek commented Jan 10, 2022

Looks good, but maybe following this suggestion and moving to chalk is better in the long run -- proposed change in #785

@thornjad please pick one of the two PRs and merge as soon as you can.

@thornjad
Copy link
Member

thornjad commented Jan 10, 2022

After catching up with the drama, I don't expect things to be resolved soon, so I agree that moving to chalk is a better long-term strategy. Closing in favor of #785, but sincere thanks for the quick fix @dballance

@thornjad thornjad closed this Jan 10, 2022
@dballance
Copy link
Author

Yep - no worries! Thanks for all the work on this great package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to work around broken dependencies (colors.js)
3 participants