Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --secure option for self signed SSL proxy support. #730

Closed
wants to merge 1 commit into from

Conversation

june07
Copy link

@june07 june07 commented Sep 24, 2021

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

#638

Without this change using the --proxy option with https fails with...
Error (404): "unable to verify the first certificate"

What changes did you make?

Added command line switch --secure to set secure to false (defaults to true)

Provide some example code that this change will affect, if applicable:

http-server --proxy https://localhost:8080? ./lib -S -C localhost.crt -K localhost.key -p 8080--secure false

@thornjad
Copy link
Member

thornjad commented Oct 5, 2021

Thank you for your PR! It hasn't been linked in the issue this PR fixes yet, but would this same functionality be achieved by #688?

@june07
Copy link
Author

june07 commented Oct 6, 2021

Possibly. I needed a fix asap so if it's useful great. If not... I look forward to the alternate fix. Cheers.

@thornjad
Copy link
Member

thornjad commented Oct 6, 2021

I'll merge #688 today or tomorrow, then make a release within the next week or two, so I'll close this in favor of the more general #688

@thornjad thornjad closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants