Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom mime-type(s) via .types file #152

Closed
wants to merge 3 commits into from

Conversation

dotnetCarpenter
Copy link

This is my take on fixing #35, if my upstream PR lands.
I need some help though. I can't figure out how to test the feature with vows. If I start http-server, I can request files with custom mime-types but no matter what I do in http-server-test.js, I get an ECONNREFUSED. I'm pretty sure it's a race condition but I can't figure out how to fix it.

Any ideas?

@indexzero
Copy link
Collaborator

Too bad you abandoned writing tests for this. I'm going to leave it open in case anyone feels compelled to write them (including myself).

@dotnetCarpenter
Copy link
Author

I might give it a shot next time I got spare time on my hands. Seems like the repo is busy at the moment - that's always encouraging.

@BigBlueHat
Copy link
Member

@dotnetCarpenter don't suppose you're still around and interested in revisiting this PR per chance? 😁

@dotnetCarpenter
Copy link
Author

dotnetCarpenter commented Apr 27, 2017 via email

@BigBlueHat
Copy link
Member

Thanks for getting this started @dotnetCarpenter! Given that the ecstatic supports it https://github.com/jfhbrook/node-ecstatic#optsmimetypes we should revisit this sometime.

I'll leave this open to track other variations or forks of this work.

Thanks again @dotnetCarpenter!

@thornjad
Copy link
Member

thornjad commented Jul 6, 2021

Should be implemented by #693, please open a new issue/PR if this is not the case

@thornjad thornjad closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants