Add tests for xmlns & xmlns:xlink parse errors #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds 14 tests for the two tree construction errors mentioned in the 12th step of "create an element for a token"[1], which currently says: > If element has an xmlns attribute in the XMLNS namespace whose value > is not exactly the same as the element's namespace, that is a parse > error. Similarly, if element has an xmlns:xlink attribute in the XMLNS > namespace whose value is not the XLink Namespace, that is a parse error. Previously these errors weren't tested at all. It's worth noting why `<html xmlns="totally not html">` isn't a parse error according to the spec: "adjust foreign attributes"[2] is only called on foreign elements (i.e. not on elements in the HTML namespace). (I would have liked to add a comment about this to the respective test cases but unfortunately the test case format doesn't support comments.) [1]: https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token [2]: https://html.spec.whatwg.org/multipage/parsing.html#adjust-foreign-attributes
not-my-profile
force-pushed
the
xmlns-errors
branch
from
86caa75
to
570cf67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds 14 tests for the two tree construction errors mentioned in the 12th step of "create an element for a token"1, which currently says:
Previously these errors weren't tested at all.
It's worth noting why
<html xmlns="totally not html">isn't a parse error according to the spec: "adjust foreign attributes"2 is only called on foreign elements (i.e. not on elements in the HTML namespace). (I would have liked to add a comment about this to the respective test cases but unfortunately the test case format doesn't support comments.)