Convert video tags to links #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't strip out `<video>` tags completely, rather convert them to bracketed links like is done for images. Relates to html-to-text#103
Also correct spacing (tabs, not spaces) in `formatVideo` function.
`video` tags don't have `alt` attributes.
Before only recognized `video` tags with a `src` attribute. Now if no `src` attribute is found, check for a `source` child element.
|
Thanks for your pull request. Before I can accept it I need some unit tests for the new feature. Please add some test cases to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, node-html-to-text ignores
videotags. This PR adds support forvideotags similar toimgtags.So if a video is encountered in either of these formats, with a
srcattribute orsourcetag......it will output a bracketed link to the video:
It also adds an
ignoreVideooption that works the same way asignoreImage.This would resolve issue #103.
My team is finding your library very useful. Thanks for creating it!