feat: 🎸 add carousel components #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Files changed 咋那麼多? 還有 CI 沒過 |
|
應該過了 我也不知道為啥那麽多 點進去看起來都沒改 |
|
要找出原因 |
|
我目前查到是換行符的問題，windows是CRLF但是我是用mac改的是LF格式，顯示有被改過的文件確實大小不一樣，大概就差’行數‘個Bytes |
|
搞定 原因是我當時在學校做一半想帶回家做直接src整包打包帶走(CRLF格式)，一般win是CRLF格式在git 的時候會自動轉LF，但是我在推的時候不知道為什麼沒轉。 |
ek2061
reviewed
Oct 27, 2022
ek2061
reviewed
Nov 3, 2022
| MyCarousel.propTypes = { | ||
| shownums: PropTypes.number, | ||
| views: PropTypes.array, | ||
| }; |
ek2061
reviewed
Nov 3, 2022
| ); | ||
|
|
||
| ObjectCard.propTypes = { | ||
| width: PropTypes.number, |
|
喔對了再自己檢查一下每個 propTypes， |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
跑馬燈獨立出一個component，箭頭固定大小、位置置中，還沒加型別檢查