http-circe: scala 3 #838
Open
http-circe: scala 3 #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriele83
commented
Nov 27, 2023
gabriele83
commented
- added scale 3 support for http circe library
- fixed implicit resolution error on circe tests
added 2 commits
November 24, 2023 16:44
- update scala 3 vesrion: 3.3.1 - cross building: akka-http-circe - removed redundant 'final' modifier - updated dependencies fix
pjfanning
reviewed
Dec 29, 2023
| @@ -102,7 +102,7 @@ trait ZioJsonSupport { | |||
| Unmarshaller(_ => | |||
| bs => { | |||
| val decoded = jd.decodeJsonStreamInput(ZStream.fromIterable(bs)) | |||
| Unsafe.unsafeCompat(implicit u => rt.unsafe.runToFuture(decoded)) | |||
| Unsafe.unsafe(implicit u => rt.unsafe.runToFuture(decoded)) | |||
There was a problem hiding this comment.
@gabriele83 I'm interested in using your changes in https://github.com/pjfanning/pekko-http-json.
Could you help by explaining why this ZIO change is useful? The rest of the PR is about Circe but I'd like to apply this change to pekko-http too if it is an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.