Enable slot HPy_tp_descr_get. #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangerer
force-pushed
the
topic/GR-51605
branch
from
3fecb22
to
7359ca0
Compare
hodgestar
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
The HPy_tp_descr_get implementation and autogen refactoring look good.
@mattip Pinging you so that you know about the autogen changes in case they surprise you when you update the vendored copy in PyPy (assuming you still have one).
|
Thanks for the heads-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slot is needed for Cython/HPy because Cython has its own function type named
cython_function_or_method.In this PR, I also refactor autogen a bit such that it is a proper package that can be imported. We will use that in GraalPy to inject our own source code generators.