added line num to Line struct #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed zero line number bug and added unit tests removed unnecessary StopAtEOF include line num count for split lines
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this change because it's generally useful to know the line number from the file being tailed. One particular case it's useful for is when the process writing to the file truncates and rewrites the entire file each time there's new content. By keeping the number of the last processed line, we can use it as a cursor to skip past lines that are sent on the Lines chan again after a re-open.
I've added a couple unit tests for it:
TestReOpenWithCursor
TestReSeekWithCursor