Update 6-authentication.md #1473
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'handler' package was updated such that the "NewDefaultServer" function cannot be found unless the package path is updated to "github.com/99designs/gqlgen/graphql/handler". Additionally, it was not specified that the server.go file is separated into its own directory. This should be addressed to avoid confusion for those presently following this tutorial.
Glyphack
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thank you @johnnyluong. The changes you made are correct, these are reflected in the reference project but I did not had write access to update them here. Hopefully a maintainer can help with this PR.
| @@ -236,6 +236,7 @@ func ForContext(ctx context.Context) *users.User { | |||
| </Instruction> | |||
|
|
|||
| Now we can use the middleware we created in our server: | |||
| Create a new folder in the root directory called 'server' and move the server.go file to the directory you just created. | |||
There was a problem hiding this comment.
This is a good suggestion which I did not know about when I wrote this. I also prefer to call the directory cmd as it's more common in the Go community.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'handler' package was updated such that the "NewDefaultServer" function cannot be found unless the package path is updated to "github.com/99designs/gqlgen/graphql/handler".
Additionally, it was not specified that the server.go file is separated into its own directory. This should be addressed to avoid confusion for those presently following this tutorial that want to run the server.