Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ! to the copyright banner comment #948

Merged
merged 1 commit into from Jul 25, 2023
Merged

Add ! to the copyright banner comment #948

merged 1 commit into from Jul 25, 2023

Conversation

afcapel
Copy link
Collaborator

@afcapel afcapel commented Jul 20, 2023

So that build tools like esbuild or rollup-plugin-license can detect the banner and keep the license in the minified output.

The banner is only a few bytes, so bundle size is not a concern.

Ref. evanw/esbuild#2745

So that build tools like esbuild or rollup-plugin-license can detect the
banner and keep the license in the minified output.

The banner is only a few bytes, so bundle size is not a concern.

Ref. evanw/esbuild#2745
Copy link
Collaborator

@kevinmcconnell kevinmcconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! And well spotted!

@afcapel afcapel merged commit 4b48b97 into main Jul 25, 2023
2 checks passed
@afcapel afcapel deleted the preseve-copyright branch July 25, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants