Introduce Turbo.config object
#1217
Open
+53
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afcapel @jorgemanrubia Trix utilizes a similar style of Object that consists of multiple modules scoped to particular concerns. |
The initial implementation aims to replace the ad hoc configurations spread across `window.Turbo` and `Turbo.session`. Those objects shouldn't be considered part of the public interface, especially for extension. This commit exports a single object from `src/core/config` to serve as a centralized, user-facing repository for configuration values. The main `src/core/config` object is composed of two constituent parts: * `src/core/config/drive` * `src/core/config/forms` In the future, the directory structure can be expanded upon to suit the needs of the project. Any user-facing configuration outside of `Turbo.config` is deprecated.
seanpdoyle
force-pushed
the
turbo-config
branch
from
6e28e7a
to
238ec26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation aims to replace the ad hoc configurations spread across
window.TurboandTurbo.session. Those objects shouldn't be considered part of the public interface, especially for extension.This commit exports a single object from
src/core/configto serve as a centralized, user-facing repository for configuration values.The main
src/core/configobject is composed of two constituent parts:src/core/config/drivesrc/core/config/formsIn the future, the directory structure can be expanded upon to suit the needs of the project.
Any user-facing configuration outside of
Turbo.configis deprecated.