Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSDoc for StreamElement #1193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update JSDoc for StreamElement #1193

wants to merge 1 commit into from

Conversation

seanpdoyle
Copy link
Contributor

The JSDoc comment for the StreamElement is incorrect, and omits several actions.

This commit sorts the list, replaces "container" with "target" (to mirror the attribute name), and mentions the missing actions.

@seanpdoyle
Update JSDoc for StreamElement
423743f 
The JSDoc comment for the `StreamElement` is incorrect, and omits
several actions.

This commit sorts the list, replaces `"container"` with `"target"` (to
mirror the attribute name), and mentions the missing actions.
seanpdoyle added a commit to seanpdoyle/turbo-site that referenced this pull request Feb 20, 2024
@seanpdoyle
Document <turbo-stream action="refresh">
f23dad0 
Related to [hotwired/turbo#1193][]

Replace all mentions of "the seven" actions with "the eight". In
addition, include examples of `<turbo-stream action="refresh">`
elements.

[hotwired/turbo#1193]: hotwired/turbo#1193
@seanpdoyle seanpdoyle mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpaulshippy tpaulshippy tpaulshippy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanpdoyle @tpaulshippy