Replace stylesheets #1180
Draft
Replace stylesheets #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjensen
force-pushed
the
replace-stylesheets
branch
2 times, most recently
from
fbd042f
to
567b55a
Compare
aaronjensen
force-pushed
the
replace-stylesheets
branch
from
567b55a
to
7720f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while our application has had this method of replacing stylesheets that maintains the order of stylesheets as best as it can and replaces stylesheets in place if only their digest has changed. This is more sophisticated than what was there originally, but you'll notice that if you attempt to use the existing
fixtures/stylesheets/left.htmlandright.htmlinteractively that it doesn't work more than once. Turbo seems to hang and then refresh the page. With this method, not only does that work, but the additional fixture I put in place that ensures there's minimal to no flicker or ordering issues works as well.I'm opening this as a draft to see if there is interest in this and/or concerns. I'm happy to clean it up if it seems like something you'd want to move forward with, which would allow us to remove our custom code from our codebase.
Thank you for the consideration.