Clarify what refresh="morph" does on turbo-frames & correct the examples #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschacht
changed the title
krschacht
commented
Feb 19, 2024
| @@ -52,8 +52,7 @@ Sometimes, you want to ignore certain elements while morphing. For example, you | |||
| You can use [turbo frames](/handbook/frames.html) to define regions in your screen that will get reloaded using morphing when a page refresh happens. To do so, you must flag those frames with `refresh="morph"`. | |||
|
|
|||
| ```html | |||
| <turbo-frame id="my-frame" refresh="morph"> | |||
| ... | |||
| <turbo-frame id="my-frame" refresh="morph" src="/my_frame"> | |||
| </turbo-frame> | |||
There was a problem hiding this comment.
refresh="morph" has no effect when there is no src on the turbo-frame. Updating this example so it's consistent with the statements below:
"...you can load additional content that didn't arrive in the initial page load ..." and "When a page refresh happens, Turbo won't remove the frame contents; instead, it will reload the turbo frame ..."
krschacht
changed the title
seanpdoyle
reviewed
Feb 20, 2024
Co-authored-by: Sean Doyle <seanpdoyle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the two examples of
turbo-framewithrefresh="morph"so they are correct. This relates to PR hotwired/turbo#1192 but it can be merged in without it since the clarifications are correct regardless of this other PR.