Pass a String to ActiveJob (rather than a SafeBuffer) #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides compatibility with Sidekiq as an ActiveJob adapter (because [Sidekiq only allows native JSON types][1] to be passed as job arguments). All credit goes to [@jdelStrother] who [suggested this solution][2]. Fixes [hotwired#522] and [hotwired#535] [1]: https://github.com/sidekiq/sidekiq/wiki/Best-Practices#1-make-your-job-parameters-small-and-simple [2]: hotwired#535 (comment) [@jdelStrother]: https://github.com/jdelStrother [hotwired#522]: hotwired#522 [hotwired#535]: hotwired#535
|
By the way, @jdelStrother, I'd be happy to close this PR if you want to create another one to be the author of the commit. |
|
No worries, happy to leave you as the author |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides compatibility with Sidekiq as an ActiveJob adapter (because Sidekiq only allows native JSON types to be passed as job arguments).
All credit goes to @jdelStrother who suggested this solution.
Fixes #522, fixes #535