Adds external_link_to helper to navigate outside of a turbo-frame #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEEKING FEEDBACK: I feel that it would be a clearer API for newer users to have an explicit `external_link_to` method instead of defining `link_to "..", target: "_top"` every time they want to link outside of a turbo-frame. If this is accepted by maintainers I will add tests and can tweak the documentation if needed.
|
In my mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEEKING FEEDBACK:
I feel that it would be a clearer API for newer users to have an explicit
external_link_tomethod instead of defininglink_to "..", target: "_top"every time they want to link outside of a turbo-frame.If this is accepted by maintainers I will add tests and can tweak the documentation if needed.