Only pass :request_id option to Refresh Stream
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
request-id-partial-local
branch
2 times, most recently
from
30243ac
to
bb56fbc
Compare
When rendering `<turbo-stream>` elements for broadcasting, **omit** the `:request_id` partial-local variable. When rendered partials utilize [Action View strict locals][], the extra variable raises an error: ``` unknown local :request_id ``` By omitting the `:request_id` from the `Turbo::Broadcastable#broadcast_rendering_with_defaults`, it isn't passed as part of partial rendering. Likewise, since `broadcast_refresh` never renders a partial, but instead builds an empty `<turbo-stream action="refresh" request-id="..."></turbo-stream>` element, the `:request_id` local variable isn't necessary. [Action view strict locals]: https://guides.rubyonrails.org/action_view_overview.html#strict-locals
seanpdoyle
force-pushed
the
request-id-partial-local
branch
from
bb56fbc
to
220fc01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering
<turbo-stream>elements for broadcasting, omit the:request_idpartial-local variable.When rendered partials utilize Action View strict locals, the extra variable raises an error:
By omitting the
:request_idfrom theTurbo::Broadcastable#broadcast_rendering_with_defaults, it isn't passed as part of partial rendering.Likewise, since
broadcast_refreshnever renders a partial, but instead builds an empty<turbo-stream action="refresh" request-id="..."></turbo-stream>element, the:request_idlocal variable isn't necessary.