Several improvements #209
Merged
Several improvements #209
+60
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+64
to
+70
| var animated: Bool { | ||
| if let animated = parameters?["animated"] as? Bool { | ||
| return animated | ||
| } | ||
|
|
||
| return true | ||
| } |
There was a problem hiding this comment.
Suggested change
| var animated: Bool { | |
| if let animated = parameters?["animated"] as? Bool { | |
| return animated | |
| } | |
| return true | |
| } | |
| var animated: Bool { parameters?["animated"] as? Bool ?? true } |
There was a problem hiding this comment.
I'd like to keep it as-is since it's consistent across all other functions in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three changes for my convenience, but I'm happy to break them up into 3 separate PRs if needed:
TurboNavigator.rootViewcontrollerallowed us to access the main nav controller. I've addedmodalRootViewControllerso we can access that too.optionsparameter. This is useful when you want to override the options given from the path config dynamically.Happy to hear any feedback.