Add cross-origin redirect delegate #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemasilotti
approved these changes
May 2, 2024
There was a problem hiding this comment.
I like this approach much better! I tested running against the demo PR and everything works as expected after adding the require delegate callback.
I added one suggestion to make the documentation even more obvious where the cross-origin redirect handling code should go.
Comment on lines
+112
to
+113
| navigationController.popViewController(animated: false) | ||
| UIApplication.shared.open(url) |
There was a problem hiding this comment.
Suggested change
| navigationController.popViewController(animated: false) | |
| UIApplication.shared.open(url) | |
| func session(_ session: Session, didProposeVisitToCrossOriginRedirect url: URL) { | |
| navigationController.popViewController(animated: false) | |
| UIApplication.shared.open(url) | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #201.
As discussed in #201 it would be preferrable to handle cross-origin redirects in the
SessionDelegate.This PR takes a stab at that to get the ball rolling so we can get feature parity between iOS and Android libs again :-)