Update Values.md documentation #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a note about value data attribute definition. Makes it clear that it should be only defined in the same place as the controller.
lb-
reviewed
Jul 19, 2023
Co-authored-by: LB (Ben Johnston) <mail@lb.ee>
marcoroth
reviewed
Jul 19, 2023
Improve text to make it more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: https://stimulus.hotwired.dev/reference/values
This PR aims to improve clarity for newcomers regarding the usage of the value data attribute. It emphasizes that the value data attribute should be defined in the same location as the controller. This clarification can help prevent unnecessary debugging efforts, as it took me around 15 minutes to resolve this issue personally.