Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the ActionEvent (with params) to registerActionOption callbacks #692

Merged
merged 1 commit into from Jun 26, 2023
Merged

Pass the ActionEvent (with params) to registerActionOption callbacks #692

merged 1 commit into from Jun 26, 2023

Conversation

lb-
Copy link
Contributor

@lb- lb- commented Jun 20, 2023

@lb-
Pass the ActionEvent (with params) to registerActionOption callbacks
f78f032 
- Add ability for registerActionOption callbacks to receive the event after `params` have been resolved
- Relates to hotwired#668
@lb- lb- force-pushed the feature/668-action-option-callback-event-with-params branch from e1f111d to f78f032 Compare June 21, 2023 07:56
@dhh dhh requested a review from adrienpoly June 24, 2023 11:21
adrienpoly
adrienpoly approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@adrienpoly adrienpoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @lb-

@dhh dhh merged commit 7bf453c into hotwired:main Jun 26, 2023
1 check passed
@lb- lb- deleted the feature/668-action-option-callback-event-with-params branch June 26, 2023 11:38
@lb-
Copy link
Contributor Author

lb- commented Jun 26, 2023

Thanks!

@marcoroth marcoroth mentioned this pull request Jul 12, 2023
Closed
@lb- lb- mentioned this pull request Jul 17, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth left review comments

@adrienpoly adrienpoly adrienpoly approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lb- @marcoroth @adrienpoly @dhh