Skip to content

Commit

Permalink
Support Node 18+ and test Node Matrix in CI (#750)
Browse files Browse the repository at this point in the history
* Test Node Matrix in CI
* Move Lint to seperate GitHub Action
* Update GitHub Actions to `@v4`
* Use Node 20
* Upgrade Karma, Qunit and related packages
* Split up Test/Build action
  • Loading branch information
marcoroth committed Feb 7, 2024
1 parent 245b06f commit 0cb23ed
Show file tree
Hide file tree
Showing 6 changed files with 470 additions and 395 deletions.
29 changes: 29 additions & 0 deletions .github/workflows/build.yml
@@ -0,0 +1,29 @@
name: Build

on: [push, pull_request]

jobs:
build:
name: Build
runs-on: ubuntu-latest
strategy:
matrix:
node: [18, 19, 20, 21]

steps:
- uses: actions/checkout@v4

- name: Setup Node v${{ matrix.node }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
cache: 'yarn'

- name: Install Dependencies
run: yarn install --frozen-lockfile

- name: Build
run: yarn build

- name: Test Build
run: yarn build:test
16 changes: 7 additions & 9 deletions .github/workflows/ci.yml → .github/workflows/lint.yml
@@ -1,24 +1,22 @@
name: CI
name: Lint

on: [push, pull_request]

jobs:
build:

lint:
name: Lint
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 21
cache: 'yarn'

- name: Install Dependencies
run: yarn install --frozen-lockfile

- name: Test
run: yarn test

- name: Lint
run: yarn lint
23 changes: 23 additions & 0 deletions .github/workflows/test.yml
@@ -0,0 +1,23 @@
name: Test

on: [push, pull_request]

jobs:
test:
name: Test
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 20
cache: 'yarn'

- name: Install Dependencies
run: yarn install --frozen-lockfile

- name: Test
run: yarn test
2 changes: 1 addition & 1 deletion .node-version
@@ -1 +1 @@
16.15.0
20.11.0
10 changes: 5 additions & 5 deletions package.json
Expand Up @@ -47,28 +47,28 @@
"devDependencies": {
"@rollup/plugin-node-resolve": "^13.0.0",
"@rollup/plugin-typescript": "^11.1.1",
"@types/qunit": "^2.9.0",
"@types/qunit": "^2.19.10",
"@types/webpack-env": "^1.14.0",
"@typescript-eslint/eslint-plugin": "^5.59.11",
"@typescript-eslint/parser": "^5.59.11",
"concurrently": "^6.2.1",
"eslint": "^8.43.0",
"eslint-config-prettier": "^8.8.0",
"eslint-plugin-prettier": "^4.2.1",
"karma": "^6.4.1",
"karma-chrome-launcher": "^3.1.1",
"karma": "^6.4.2",
"karma-chrome-launcher": "^3.2.0",
"karma-qunit": "^4.1.2",
"karma-sauce-launcher": "^4.3.6",
"karma-webpack": "^4.0.2",
"prettier": "^2.8.8",
"qunit": "^2.9.2",
"qunit": "^2.20.0",
"rimraf": "^3.0.2",
"rollup": "^2.53",
"rollup-plugin-terser": "^7.0.2",
"ts-loader": "^9.4.3",
"tslib": "^2.5.3",
"typescript": "^5.1.3",
"webpack": "^4.39.1"
"webpack": "^4.47.0"
},
"resolutions": {
"webdriverio": "^7.19.5"
Expand Down

0 comments on commit 0cb23ed

Please sign in to comment.