Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow us to close registration #403

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Allow us to close registration #403

merged 4 commits into from
Dec 16, 2023

Conversation

edwardloveall
Copy link
Member

@edwardloveall edwardloveall commented Dec 15, 2023

We're overwhelmed with new registrations. This allow us to set the environment variable CLOSED_FOR_REGISTRATION=1 which will allow all existing registrations to work, but redirect all new registrations to a "closed" page.

It also updates the homepage to show that we're closed so people can easily see before signing up.

Note that this is different from the
DISALLOW_CREATING_NEW_REDIRECTIONS config, which is more like a shadow ban when we're getting a bunch of spam. It does not show a message. Surprisingly different implementations!

Firefox Developer Edition

We're overwhelmed with new registrations. This allow us to set the
environment variable `CLOSED_FOR_REGISTRATION=1` which will allow all
existing registrations to work, but redirect all new registrations to a
"closed" page.

It also updates the homepage to show that we're closed so people can
easily see before signing up.

Note that this is different from the
`DISALLOW_CREATING_NEW_REDIRECTIONS` config, which is more like a
shadow ban when we're getting a bunch of spam. It does not show a
message. Surprisingly different implementations!
Copy link
Member

@gabebw gabebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for building this! I have some small nits, mostly around prose.

.sample.env Show resolved Hide resolved
app/assets/stylesheets/_pages.scss Show resolved Hide resolved
app/services/redirection_creation.rb Outdated Show resolved Hide resolved
app/views/pages/_closed_text.html.erb Outdated Show resolved Hide resolved
app/views/homes/show.html.erb Outdated Show resolved Hide resolved
app/views/homes/show.html.erb Outdated Show resolved Hide resolved
app/views/pages/_closed_text.html.erb Outdated Show resolved Hide resolved
spec/services/redirection_creation_spec.rb Outdated Show resolved Hide resolved
@edwardloveall edwardloveall merged commit 1cd3d28 into main Dec 16, 2023
1 check passed
@edwardloveall edwardloveall deleted the el-closed branch December 16, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants