Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky ray tests #3430

Merged
merged 9 commits into from Mar 1, 2022
Merged

Fix flaky ray tests #3430

merged 9 commits into from Mar 1, 2022

Commits on Mar 1, 2022

  1. Improve assertion to better understand flaky assertion 

    Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    51054d8 View commit details
    Browse the repository at this point in the history

  2. Focus on flaky tests 

    Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    fbe1ce5 View commit details
    Browse the repository at this point in the history

  3. Revert "Focus on flaky tests" 

    This reverts commit 6f9e7f9.

Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    84b473d View commit details
    Browse the repository at this point in the history

  4. Fix typos 

    Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    7634655 View commit details
    Browse the repository at this point in the history

  5. Run Buildkite pipelines right after init 

    Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    930398f View commit details
    Browse the repository at this point in the history

  6. Remove check_resources from test_ray.py as it has race conditions 

    Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    51a6b59 View commit details
    Browse the repository at this point in the history

  7. Restore CUDA_VISIBLE_DEVICES after test 

    Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    b9d7507 View commit details
    Browse the repository at this point in the history

  8. Revert "Run Buildkite pipelines right after init" 

    This reverts commit df5a49b.

Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    d627a27 View commit details
    Browse the repository at this point in the history

  9. Test orig_devices for not None 

    Signed-off-by: Enrico Minack <github@enrico.minack.dev>
    @EnricoMi
    EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    0f047ff View commit details
    Browse the repository at this point in the history