Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indices in initial task-to-task registration #3410

Merged
merged 1 commit into from Feb 28, 2022
Merged

Fix indices in initial task-to-task registration #3410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions horovod/spark/runner.py
View file
Open in desktop
Expand Up @@ -167,21 +167,23 @@ def _notify_and_register_task_addresses(driver, settings, notify=True):
if settings.verbose >= 2:
logging.info('Initial Spark task registration is complete.')

def notify_and_register(index):
task_client = task_service.SparkTaskClient(index,
driver.task_addresses_for_driver(index),
task_indices = driver.task_indices()
task_pairs = zip(task_indices, task_indices[1:] + task_indices[0:1])

def notify_and_register(task_index, next_task_index):
task_client = task_service.SparkTaskClient(task_index,
driver.task_addresses_for_driver(task_index),
settings.key, settings.verbose)

if notify:
task_client.notify_initial_registration_complete()

next_task_index = (index + 1) % settings.num_proc
next_task_addresses = driver.all_task_addresses(next_task_index)
task_to_task_addresses = task_client.get_task_addresses_for_task(next_task_index, next_task_addresses)
driver.register_task_to_task_addresses(next_task_index, task_to_task_addresses)

for index in driver.task_indices():
in_thread(notify_and_register, (index,))
for task_index, next_task_index in task_pairs:
in_thread(notify_and_register, (task_index, next_task_index))

driver.wait_for_task_to_task_address_updates(settings.start_timeout)

Expand Down