Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Horovod with temporarily installed CMake if necessary #3371

Merged
merged 7 commits into from Mar 1, 2022
Merged

Build Horovod with temporarily installed CMake if necessary #3371

merged 7 commits into from Mar 1, 2022

Commits on Mar 1, 2022

  1. Use CMake from a temp environment if system version is too old 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach @EnricoMi
    maxhgerlach authored and EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    c874211 View commit details
    Browse the repository at this point in the history

  2. Removed gpg install from Dockerfiles 

    (accidental remainder from previous PR)

Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach @EnricoMi
    maxhgerlach authored and EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    c3569be View commit details
    Browse the repository at this point in the history

  3. Update install docs 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach @EnricoMi
    maxhgerlach authored and EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    ef92e72 View commit details
    Browse the repository at this point in the history

  4. Don't preinstall CMake 3.13 in test Dockerfiles 

    This tests that Horovod can be built with an automatically installed CMake from a temp dir.

Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach @EnricoMi
    maxhgerlach authored and EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    d0dffc6 View commit details
    Browse the repository at this point in the history

  5. Install CMake 3.13 in image for CodeQL 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach @EnricoMi
    maxhgerlach authored and EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    6de2b48 View commit details
    Browse the repository at this point in the history

  6. Broaden except clause to catch subprocess.CalledProcessError too 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach @EnricoMi
    maxhgerlach authored and EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    072ec9e View commit details
    Browse the repository at this point in the history

  7. Use CMake from apt in containers based on Ubuntu 20.04 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach @EnricoMi
    maxhgerlach authored and EnricoMi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    5ef9e2b View commit details
    Browse the repository at this point in the history