Fix possible integer overflow in multiplication #3368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL identified a few integer multiplications that might overflow before cast to a larger type:
See CWE-190 CWE-192 CWE-197 CWE-681.
Fixes:
https://github.com/horovod/horovod/security/code-scanning/3
https://github.com/horovod/horovod/security/code-scanning/4
https://github.com/horovod/horovod/security/code-scanning/5
https://github.com/horovod/horovod/security/code-scanning/6
https://github.com/horovod/horovod/security/code-scanning/7
https://github.com/horovod/horovod/security/code-scanning/8
See: https://github.com/horovod/horovod/runs/4816240959