Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Horovod pyarrow IndexError: list index out of range #3274

Merged
merged 11 commits into from Nov 22, 2021

Conversation

WeichenXu123
Copy link
Contributor

@WeichenXu123 WeichenXu123 commented Nov 12, 2021

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes #2193 .
Fix Horovod pyarrow IndexError: list index out of range

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123
Copy link
Contributor Author

@tgaddair I created a new PR for #2193 , could you help review ? It should address the issue mentioned here: #3255 (comment)
CC @EnricoMi

@github-actions
Copy link

github-actions bot commented Nov 12, 2021

Unit Test Results

     766 files  ±0       766 suites  ±0   6h 6m 23s ⏱️ -48s
     602 tests ±0       566 ✔️ ±0       36 💤 ±0  0 ±0 
16 260 runs  ±0  11 387 ✔️ ±0  4 873 💤 ±0  0 ±0 

Results for commit 2b88126. ± Comparison against base commit d395a88.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 12, 2021

Unit Test Results (with flaky tests)

     876 files   -     2       876 suites   - 2   6h 28m 31s ⏱️ - 1m 45s
     602 tests ±    0       566 ✔️ +    1       36 💤 ±  0  0  - 1 
18 734 runs   - 174  12 861 ✔️  - 255  5 873 💤 +82  0  - 1 

Results for commit 2b88126. ± Comparison against base commit d395a88.

♻️ This comment has been updated with latest results.

horovod/spark/common/util.py Outdated Show resolved Hide resolved
horovod/spark/common/util.py Show resolved Hide resolved
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase to / merge latest master please? Then I will run the Spark tests on this branch (those that are currently disabled) to check they do not break on this fix.

horovod/spark/common/util.py Outdated Show resolved Hide resolved
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@EnricoMi
Copy link
Collaborator

@WeichenXu123 I am running this branch with all Spark tests reactivated (#3263) in #3283.

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are green: #3283

@EnricoMi EnricoMi merged commit 6e7464a into horovod:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Horovod pyarrow IndexError: list index out of range
2 participants