Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue 2322 #3203

Closed
wants to merge 1 commit into from
Closed

Fix for Issue 2322 #3203

wants to merge 1 commit into from

Conversation

surak
Copy link

@surak surak commented Oct 7, 2021

Please see
#2322 (comment)

Checklist before submitting

  • Did you read the contributor guide?
  • [] Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes # 2322.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Unit Test Results

     807 files  ±0       807 suites  ±0   7h 10m 22s ⏱️ +57s
     701 tests ±0       657 ✔️ ±0       44 💤 ±0  0 ❌ ±0 
17 497 runs  ±0  12 292 ✔️ ±0  5 205 💤 ±0  0 ❌ ±0 

Results for commit 9b38776. ± Comparison against base commit dadca53.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Unit Test Results (with flaky tests)

     917 files   -   30       917 suites   - 30   7h 32m 57s ⏱️ - 15m 14s
     701 tests ±    0       658 ✔️ +    2       43 💤 ±    0  0 ❌  - 2 
19 837 runs   - 747  13 696 ✔️  - 552  6 141 💤  - 193  0 ❌  - 2 

Results for commit 9b38776. ± Comparison against base commit dadca53.

@maxhgerlach maxhgerlach self-requested a review October 18, 2021 14:37
maxhgerlach
maxhgerlach reviewed Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@maxhgerlach maxhgerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @surak,

thanks for contributing to Horovod and looking into making build failures easier to understand.

cmake/Modules/FindTensorflow.cmake Show resolved Hide resolved
@stale
Copy link

stale bot commented Dec 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 17, 2021
@surak
Copy link
Author

surak commented Dec 18, 2021

How can I fix this thing?

@stale stale bot removed the wontfix label Dec 18, 2021
@maxhgerlach
Copy link
Collaborator

Hi @surak, I wasn't sure whether you wanted to give the suggestions from the other thread a go or not.

@maxhgerlach maxhgerlach mentioned this pull request Feb 3, 2022
Merged
@stale
Copy link

stale bot commented Feb 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 19, 2022
@surak
Copy link
Author

surak commented Feb 19, 2022

Hi @surak, I wasn't sure whether you wanted to give the suggestions from the other thread a go or not.

If that one solves it, I’m happy!

@stale stale bot removed the wontfix label Feb 19, 2022
@EnricoMi
Copy link
Collaborator

This has been fixed in #3398 across all CMake modules and released in v0.24.0: 046c071

@EnricoMi EnricoMi closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhgerlach maxhgerlach maxhgerlach left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@surak @maxhgerlach @EnricoMi