Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in-place broadcast for TensorFlow #3128

Merged
merged 8 commits into from Oct 20, 2021
Merged

Add in-place broadcast for TensorFlow #3128

merged 8 commits into from Oct 20, 2021

Commits on Oct 15, 2021

  1. Update comment in FindTensorflow.cmake 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach
    maxhgerlach committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    90d7564 View commit details
    Browse the repository at this point in the history

  2. Add in-place broadcast_() and broadcast_variables() for TF 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach
    maxhgerlach committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    1ecaf2a View commit details
    Browse the repository at this point in the history

  3. Include source files from TF in build to avoid missing symbol errors 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach
    maxhgerlach committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    bccbade View commit details
    Browse the repository at this point in the history

  4. Limit build and test to TF 2.6+ 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach
    maxhgerlach committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    c9abe2b View commit details
    Browse the repository at this point in the history

  5. Remove source files copied from TensorFlow 

    The missing symbols are resolved by linking against _pywrap_tensorflow_internal.so,
which was introduced to Horovod with PR horovod#3053.

Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach
    maxhgerlach committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    f3627fb View commit details
    Browse the repository at this point in the history

  6. Fix possible type attribute values for HorovodBroadcastInplace 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach
    maxhgerlach committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5747673 View commit details
    Browse the repository at this point in the history

  7. Add reference variables to test 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach
    maxhgerlach committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    206ebf8 View commit details
    Browse the repository at this point in the history

  8. Update comments, doc strings, changelog 

    Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
    @maxhgerlach
    maxhgerlach committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    dd942ff View commit details
    Browse the repository at this point in the history