Fix flaky ray tests #3430
Merged
Fix flaky ray tests #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results (with flaky tests) 886 files - 74 886 suites - 74 9h 59m 22s ⏱️ + 5m 27s Results for commit d627a27. ± Comparison against base commit 7b5346e. ♻️ This comment has been updated with latest results. |
EnricoMi
force-pushed
the
branch-fix-flaky-ray-tests
branch
5 times, most recently
from
06e9969
to
4e9c44c
Compare
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
This reverts commit 6f9e7f9. Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
This reverts commit df5a49b. Signed-off-by: Enrico Minack <github@enrico.minack.dev>
EnricoMi
force-pushed
the
branch-fix-flaky-ray-tests
branch
from
d21b8a2
to
d627a27
Compare
tgaddair
reviewed
Mar 1, 2022
test/single/test_ray.py
Outdated
| # The code after the yield will run as teardown code. | ||
| ray.shutdown() | ||
| finally: | ||
| if orig_devices: |
There was a problem hiding this comment.
None and "" have different meanings for CUDA_VISIBLE_DEVICES. Probably safer to be explicit:
if orig_devices is not None:
...
There was a problem hiding this comment.
Alright, will better do that then.
tgaddair
approved these changes
Mar 1, 2022
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
EnricoMi
force-pushed
the
branch-fix-flaky-ray-tests
branch
from
477a95a
to
0f047ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ray tests assert that available ray resources after the test are identical to before the test. This turns out to be flaky.
This removes the
check_resourcesassertion as it has race conditions. Further, this restores theCUDA_VISIBLE_DEVICESenvironment variable after tests finish that modify it.And this improves assertion context to further debug the issue of 8 GPUs though 4 workers have been started.