Skip to content

Commit

Permalink
Use CMake from apt in containers based on Ubuntu 20.04
Browse files Browse the repository at this point in the history
Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
  • Loading branch information
maxhgerlach committed Mar 1, 2022
1 parent 52162cb commit 01f9ede
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 12 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/codeql-analysis.yml
Expand Up @@ -100,9 +100,6 @@ jobs:
sed -i -e "s%^# setup ssh service$%${command//$'\n'/\\n}\n\n# setup ssh service%" Dockerfile.test.?pu
command=$(cat <<EOF
# Install recent CMake
RUN pip install --no-cache-dir -U cmake~=3.13.0
# Setup CodeQL tracing
RUN mkdir -p /home/runner/work/horovod
RUN ln -s /horovod /home/runner/work/horovod/horovod
Expand Down
1 change: 1 addition & 0 deletions docker-compose.test.yml
Expand Up @@ -59,6 +59,7 @@ services:
args:
# Tensorflow 1.15.5 is only available for Python 3.7
# Python 3.7 is only available on Ubuntu 18.04
# On Ubuntu 18.04 our setup.py will pull in a recent CMake and use that only to build Horovod
UBUNTU_VERSION: 18.04
PYTHON_VERSION: 3.7
# there is no tensorflow-cpu>1.15.0, so we use tensorflow==1.15.5
Expand Down
4 changes: 1 addition & 3 deletions docker/horovod-cpu/Dockerfile
Expand Up @@ -17,6 +17,7 @@ SHELL ["/bin/bash", "-euo", "pipefail", "-c"]

RUN apt-get update && apt-get install -y --allow-downgrades --allow-change-held-packages --no-install-recommends \
build-essential \
cmake \
g++-7 \
git \
curl \
Expand Down Expand Up @@ -55,9 +56,6 @@ RUN curl -O https://bootstrap.pypa.io/get-pip.py && \
python get-pip.py && \
rm get-pip.py

# Install recent CMake.
RUN pip install --no-cache-dir -U cmake~=3.13.0

# Install PyTorch, TensorFlow, Keras and MXNet
RUN pip install --no-cache-dir torch==${PYTORCH_VERSION} torchvision==${TORCHVISION_VERSION}
RUN pip install --no-cache-dir pytorch_lightning==${PYTORCH_LIGHTNING_VERSION}
Expand Down
4 changes: 1 addition & 3 deletions docker/horovod-ray/Dockerfile
Expand Up @@ -15,16 +15,14 @@ SHELL ["/bin/bash", "-euo", "pipefail", "-c"]

RUN sudo apt-get update && DEBIAN_FRONTEND="noninteractive" sudo apt-get install -y \
build-essential \
cmake \
wget \
git \
curl \
rsync \
vim \
&& sudo apt-get clean && sudo rm -rf /var/lib/apt/lists/*

# Install recent CMake.
RUN pip install --no-cache-dir -U cmake~=3.13.0

# Install PyTorch
RUN pip install --no-cache-dir \
torch==${PYTORCH_VERSION} \
Expand Down
4 changes: 1 addition & 3 deletions docker/horovod/Dockerfile
Expand Up @@ -23,6 +23,7 @@ SHELL ["/bin/bash", "-euo", "pipefail", "-c"]

RUN apt-get update && apt-get install -y --allow-downgrades --allow-change-held-packages --no-install-recommends \
build-essential \
cmake \
g++-7 \
git \
curl \
Expand Down Expand Up @@ -67,9 +68,6 @@ RUN curl -O https://bootstrap.pypa.io/get-pip.py && \
rm get-pip.py && \
pip install --no-cache-dir -U --force pip~=21.0.0

# Install recent CMake.
RUN pip install --no-cache-dir -U cmake~=3.13.0

# Install PyTorch, TensorFlow, Keras and MXNet
RUN pip install --no-cache-dir \
torch==${PYTORCH_VERSION} \
Expand Down

0 comments on commit 01f9ede

Please sign in to comment.