Fix compilation of smart contracts in Docker containers #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build was broken due to more recent `solc` requiring libc compat files in Alpine and Hardhat ignoring errors from the execution of `solc`. This led to deadlocked compilation attempts. Hardhat fix: NomicFoundation/hardhat#3284 This changes adds the required compat files in our Alpine image as well.
tolbrino
added
bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Good catch. We may need to back-port this to |
NumberFour8
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was broken due to more recent
solcrequiring libc compat files in Alpine and Hardhat ignoring errors from the execution ofsolc. This led to deadlocked compilation attempts.Hardhat fix: NomicFoundation/hardhat#3284
This changes adds the required compat files in our Alpine image as well.