Enable new Rubocop 80 cops #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubocop will not enable new "default" cops until major releases now. rubocop/rubocop#7731
Loubz
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
Je pense qu'on peut les activer sans trop de problème. À la limite ça va ajouter des correctifs mineurs sur certains projets, mais ce ne sont pas des pratiques que j'ai vu souvent dans les projets jusqu'à maintenant.
Je vous sauve le googling pour aller voir exactement ce que ça fait:
goduchesne
approved these changes
Feb 24, 2020
j15e
approved these changes
Feb 24, 2020
|
C'est dans style mais ça aurait pratiquement pu être dans performance. Bonnes choses à savoir / utiliser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop will not enable new "default" cops until major releases now. It's up to us to enable them if we want.
rubocop/rubocop#7731