Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix code coverage #197

Merged
merged 2 commits into from Jul 26, 2022
Merged

CI: fix code coverage #197

merged 2 commits into from Jul 26, 2022

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Jul 25, 2022

Noticed only one of the two files was being processed. Tipped off by codecov/codecov-action#325 that allowing automatic detection fixed their use and it appears to here as well?!

@jharley jharley requested a review from dstrelau as a code owner July 25, 2022 21:36
@mitchell-codecov
Copy link

mitchell-codecov commented Jul 26, 2022

Hey, @jharley. I saw your comment over in codecov/codecov-action#325 and was able to reproduce the issue.

Keep an eye on codecov/codecov-action#791 since it'll fix the issue once it's merged.

In the meantime, here is a comparison of the behavior you were seeing running on a fork of this repository (diff):

Here is a comparison of the changes made in the fork between those two runs.

@jharley
Copy link
Collaborator Author

jharley commented Jul 26, 2022

Hey, @mitchell-codecov! Thanks for digging into it.. I missed the trailing whitespace but I'm sure I wouldn't have been the last either

@jharley jharley merged commit a82c49b into main Jul 26, 2022
@jharley jharley deleted the jharley.fix-coverage branch July 26, 2022 16:05
@jharley
Copy link
Collaborator Author

jharley commented Jul 26, 2022

Introduced by #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants