split components module #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an example of using the following components with a vanilla OTel setup: - local visualization through the SpanLinkExporter + SimpleSpanProcessor - deterministic sample - baggage span processor Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
MikeGoldsmith
added
type: enhancement
|
We're not going ahead with breaking distro. Individual parts will only available as part of the distro. Baggage span processor is being contributed to otel-go-contrib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Reduce the scope of the package users must import to use the SpanLinkExporter, BaggageSpanProcessor, and DeterministicSampler
Short description of the changes
This change creates the
"github.com/honeycombio/honeycomb-opentelemetry-go/components"module that includes the same methods that were previously available from"github.com/honeycombio/honeycomb-opentelemetry-go". The other update in this change is the import of that package for the distro.How to verify that this has the expected result
Smoke tests continue to pass