Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tag ID if no name, sort by last updated on mobile #20788

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented May 13, 2024

Breaking change

Proposed change

We were computing display name but weren't actually rendering it, causing tags without a name to show an empty field.

I've also marked the last scanned column as hidden on narrow, instead of not defining it. This allows users to still sort by it on mobile, as the data will be visible on the UI as 2nd row.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya merged commit d046700 into dev May 13, 2024
14 checks passed
@piitaya piitaya deleted the tag-tweaks branch May 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants