Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the way the update shows available updates #20773

Merged
merged 7 commits into from May 22, 2024

Conversation

nielsnl68
Copy link
Contributor

Breaking change

When the Update display is shown, the top section shows the new version number. To me it looks as if that is the current version.
Showing the new version was already shown double.

Proposed change

This PR will change this by showing "Update Available" instead.

ESPHome (dev) Update
3 uur geleden                                2024.6.0-dev20240510

into:

ESPHome (dev) Update
3 uur geleden                                    Update available

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

No Change in configuration scripts needed.

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nielsnl68

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 10, 2024 17:20
@nielsnl68 nielsnl68 marked this pull request as ready for review May 10, 2024 17:20
src/data/update.ts Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 22, 2024 13:08
nielsnl68 and others added 2 commits May 22, 2024 15:11
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
src/data/update.ts Outdated Show resolved Hide resolved
src/translations/en.json Outdated Show resolved Hide resolved
@nielsnl68 nielsnl68 requested a review from piitaya May 22, 2024 13:23
@nielsnl68 nielsnl68 marked this pull request as ready for review May 22, 2024 13:24
piitaya
piitaya previously approved these changes May 22, 2024
@piitaya piitaya enabled auto-merge (squash) May 22, 2024 13:28
src/data/update.ts Outdated Show resolved Hide resolved
@piitaya piitaya merged commit a500b58 into home-assistant:dev May 22, 2024
13 checks passed
@nielsnl68 nielsnl68 deleted the nvds-update_display_msg branch May 22, 2024 21:56
@nielsnl68
Copy link
Contributor Author

thanks for the merge :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants