Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Macedonian (Македонски) to the frontend. #20701

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

glisha
Copy link

@glisha glisha commented May 2, 2024

Proposed change

Add new language (Macedonian, mk) to the frontend.

Was following: https://developers.home-assistant.io/docs/translations/#maintainer-steps-to-add-a-new-language

Steps 1 and 2 from there will be done with this pull request being merged.

  1. It has the "mk" code in the IANA subtag registry.
  2. Adding it in src/translations/translationMetadata.json

The third step adding it in Lokalize needs to be done by a maintainer.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Following: https://developers.home-assistant.io/docs/translations/#maintainer-steps-to-add-a-new-language

Steps 1 and 2.

- It has the "mk" code in the IANA subtag registry.
- Adding it in src/translations/translationMetadata.json
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @glisha

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft May 2, 2024 17:01
@home-assistant
Copy link

home-assistant bot commented May 2, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@glisha glisha marked this pull request as ready for review May 2, 2024 17:11
@bramkragten
Copy link
Member

bramkragten commented May 6, 2024

Can you send me the email address you use for your Lokalise account so I can add you to the Macedonian language?

@glisha
Copy link
Author

glisha commented May 6, 2024

Can you send me the email address you use for your Lokalise account so I can add you to the Macedonian language?

It is my github username @gmail.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants