Rename "Twitter" to "X (formerly Twitter)" #20694
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silamon
reviewed
May 2, 2024
| @@ -67,7 +67,7 @@ const randomTip = (hass: HomeAssistant, narrow: boolean) => { | |||
| href=${documentationUrl(hass, `/twitter`)} | |||
| target="_blank" | |||
| rel="noreferrer" | |||
| >Twitter</a | |||
| >X (formerly Twitter)</a | |||
There was a problem hiding this comment.
This needs to be added to the translation file. Then use the translation key in the links.
There was a problem hiding this comment.
(@silamon if you request changes in your review, the PR is automatically put in to draft and a message is added by the bot explaining why etc)
piitaya
reviewed
May 13, 2024
| @@ -6816,7 +6816,7 @@ | |||
| "forums": "Home Assistant forums", | |||
| "open_home_newsletter": "Building the Open Home newsletter", | |||
| "discord": "Discord chat", | |||
| "twitter": "Twitter", | |||
| "twitter": "X (formerly Twitter)", | |||
There was a problem hiding this comment.
We can also change the key to x. It will invalidate the translation for all languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: