Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump webpack to v5.72.1 and tweak stats scripts #15516

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Bump webpack to v5.72.1 and tweak stats scripts #15516

merged 2 commits into from
Feb 21, 2023

Conversation

steverep
Copy link
Member

@steverep steverep commented Feb 21, 2023

Proposed change

This bumps webpack to version 5.72.1, stopping short of the latest 5.75.0. Something breaks from 5.72.1 to 5.73.0 to cause the bundles not to load at all in the browser, with no compilation or runtime errors. I haven't been able to figure out the cause, but the symptoms point to a runtime/manifest issue.

Compared to our current version of 5.55.1, 5.72.1 is nearly identical in terms of basic stats, except it compiles about 20% faster.

The scripts that run the CLI to get detailed stats also needed some tweaking.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@steverep steverep added the Dependencies Pull requests that update a dependency file label Feb 21, 2023
@bramkragten bramkragten merged commit a469a92 into dev Feb 21, 2023
@bramkragten bramkragten deleted the bump-webpack branch February 21, 2023 08:50
@steverep
Copy link
Member Author

FYI - webpack/webpack#16097 seems like it could be the same issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants