Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.8.4 #88032

Merged
merged 1 commit into from Feb 13, 2023
Merged

Bump aiohttp to 3.8.4 #88032

merged 1 commit into from Feb 13, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 13, 2023

Proposed change

changelog: aio-libs/aiohttp@v3.8.1...v3.8.4

Has aio-libs/aiohttp#7180 which is the fix we have been waiting for

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

changelog: aio-libs/aiohttp@v3.8.1...v3.8.4

Has aio-libs/aiohttp#7180 which is the fix we have been waiting for
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@bdraco
Copy link
Member Author

bdraco commented Feb 13, 2023

thanks

@bdraco bdraco merged commit 026b4f5 into dev Feb 13, 2023
@bdraco bdraco deleted the aiohttp384 branch February 13, 2023 21:52
@balloob
Copy link
Member

balloob commented Feb 14, 2023

This release of aiohttp still adopts the new behavior that view handlers now no longer get cancelled if the client leaves.

See my comment here

@balloob
Copy link
Member

balloob commented Feb 14, 2023

We need aiohttp 3.9 so we can use aio-libs/aiohttp#7056 which gives us the old behavior.

@balloob
Copy link
Member

balloob commented Feb 14, 2023

So the new behavior means we don't cancelled the handler but instead rely on errors being raised when we send data to the client. This was broken in 3.8.3 but now works thanks to the fix by bdraco in 3.8.4 (previously we would just run out of memory).

However, this new behavior means all view handlers are now behaving differently than before, and we haven't verified this (and need to verify this for all views? 😱).

@balloob
Copy link
Member

balloob commented Feb 14, 2023

For more about the differences between the two, see https://github.com/aio-libs/aiohttp/blob/master/docs/web_advanced.rst#web-handler-cancellation

bdraco added a commit to bdraco/home-assistant that referenced this pull request Feb 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants