Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HomeKit media players when entity has duplicate sources #83890

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 13, 2022

Proposed change

fixes #83852 fixes #83698

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob merged commit 692a732 into home-assistant:dev Dec 13, 2022
@balloob balloob modified the milestones: 2022.12.5, 2022.12.4 Dec 13, 2022
This was referenced Dec 13, 2022
@kleytonn
Copy link

Hi there,

You are really fast! Thanks!

My model is a 2016 Sony XBR49X835D Android 9 and it has a Chrome Cast integration and DLNA integration. I think 'cause that Home Assistant log more than one media player. But they don't have the same identification.

media_player.living_room_tv --> Google Cast
media_player.living_room_tv_2 --> DLNA Digital Media Renderer
media_player.sony_xbr_49x835d --> Sony Bravia TV

That fix 2012.12.4 solved the problem with HomeKit integration but now TV sources (channels, apps and inputs) are not showing in Apple HomeKit like before. Only have on/off option.

If I downgrade to 2022.10.5 everything works fine.

@frenck
Copy link
Member

frenck commented Dec 13, 2022

@kleytonn If you are experiencing an issue with an integration, please raise an issue in the issue tracker (instead of commenting on handled pull requests). These comments are hard to track and triage, issue make that easier.

Thanks! 👍

../Frenck

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants