Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyJWT to 2.5.0 #78776

Merged
merged 2 commits into from Sep 20, 2022
Merged

Update PyJWT to 2.5.0 #78776

merged 2 commits into from Sep 20, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Sep 19, 2022

Proposed change

Updates PyJWT to 2.5.0
https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst#v250

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@frenck frenck requested a review from a team as a code owner September 19, 2022 15:50
@probot-home-assistant probot-home-assistant bot added core dependency small-pr PRs with less than 30 lines. labels Sep 19, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Sep 19, 2022
@frenck frenck marked this pull request as draft September 19, 2022 19:04
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Sep 19, 2022
@frenck
Copy link
Member Author

frenck commented Sep 19, 2022

There seems to be a breaking change that affects us: jpadilla/pyjwt#806

Although it is not listed a breaking change (or as a change at all), thus awaiting the result of the issue upstream.

../Frenck

@frenck
Copy link
Member Author

frenck commented Sep 20, 2022

The change is caused by a difference in order (sorted keys). I've updated the key so the tests will now pass.

@frenck frenck marked this pull request as ready for review September 20, 2022 13:30
@frenck frenck merged commit 774d513 into dev Sep 20, 2022
@frenck frenck deleted the frenck-2022-1855 branch September 20, 2022 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants